Bug 207536

Summary:	Regression r256298: WPE build broken
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	WPE WebKit	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, bugs-noreply, cgarcia, clopez, mcatanzaro, webkit-bot-watchers-bugzilla
Priority:	P2
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=206999

Description Aakash Jain 2020-02-11 04:42:23 PST

WPE build seems to be broken since r256298.

r256297 passed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Debug%20%28Build%29/builds/16189
r256298 failed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Debug%20%28Build%29/builds/16189

Similarly for release:
r256297 passed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/29093
r256298 failed in https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/29094


Logs:
FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-46.cpp.o 
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-46.cpp:1:
../../Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp: In member function ‘void WebCore::ResourceRequest::updateFromSoupMessage(SoupMessage*)’:
../../Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:186:23: error: ‘areRegistrableDomainsEqual’ was not declared in this scope
         setIsSameSite(areRegistrableDomainsEqual(soupURIToURL(siteForCookies), m_url));

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-3.cpp:2:
../../Source/WebCore/rendering/HighlightData.cpp: In member function ‘WebCore::RenderObject::HighlightState WebCore::HighlightData::highlightStateForRenderer(WebCore::RenderObject&)’:
../../Source/WebCore/rendering/HighlightData.cpp:174:19: warning: variable ‘highlightEnd’ set but not used [-Wunused-but-set-variable]
     RenderObject* highlightEnd = nullptr;
                   ^~~~~~~~~~~~

Comment 1 Carlos Alberto Lopez Perez 2020-02-11 04:59:11 PST

Thanks for the report.

Not sure if r256298 actually caused it, but at least triggered the failure.

I see r256298 touches SourcesWPE.txt, that causes the CMake cache to be cleared when a re-build its attempted (which the bot did)

I have triggered a clean build in GTK-Release bot to see if its also affected.

Comment 2 Carlos Garcia Campos 2020-02-11 05:05:35 PST

Committed r256301: <https://trac.webkit.org/changeset/256301>