Bug 207520

Summary: [iOS] Crash when granting access to asset services
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2020-02-10 16:41:30 PST 
When the WKWebView is being granted access to asset services, the WebContent process is crashing.
Comment 1 Per Arne Vollan 2020-02-10 16:56:56 PST 
rdar://problem/59321848
Comment 2 Per Arne Vollan 2020-02-10 16:57:52 PST 
Created attachment 390319 [details]
Patch
Comment 3 Brent Fulgham 2020-02-10 17:01:10 PST 
Comment on attachment 390319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390319&action=review

r=me

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1522
> +    SandboxExtension::createHandleForMachLookup("com.apple.mobileassetd.v2", WTF::nullopt, mobileAssetHandleV2);

Doh! I missed that earlier.
Comment 4 Per Arne Vollan 2020-02-10 17:02:12 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 390319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390319&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1522
> > +    SandboxExtension::createHandleForMachLookup("com.apple.mobileassetd.v2", WTF::nullopt, mobileAssetHandleV2);
> 
> Doh! I missed that earlier.

Me too!
Comment 5 Per Arne Vollan 2020-02-10 17:02:32 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 390319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=390319&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1522
> > +    SandboxExtension::createHandleForMachLookup("com.apple.mobileassetd.v2", WTF::nullopt, mobileAssetHandleV2);
> 
> Doh! I missed that earlier.

Thanks for reviewing!
Comment 6 WebKit Commit Bot 2020-02-10 17:46:08 PST 
Comment on attachment 390319 [details]
Patch

Clearing flags on attachment: 390319

Committed r256234: <https://trac.webkit.org/changeset/256234>
Comment 7 WebKit Commit Bot 2020-02-10 17:46:09 PST 
All reviewed patches have been landed.  Closing bug.