Bug 207510

Summary:

[ews] Add build-steps to close bug and clear flags on patch for commit queue in new ews

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED WORKSFORME

Severity:

Normal

CC:

aakash_jain, ap, jbedard

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-02-10 14:20:58 PST

Add build-steps to close bug and clear flags on patch for commit queue in new ews.

Comment 1 Aakash Jain 2020-02-10 14:25:51 PST

Created attachment 390296 [details]
Patch

Comment 2 Aakash Jain 2020-02-10 14:28:58 PST

Now that Bug 207492 is fixed, and layout-test step doesn't immediately finish the build, we can add these build-steps.

Sample runs:
with pre-existing failures: https://ews-build.webkit-uat.org/#/builders/26/builds/430
without failures: https://ews-build.webkit-uat.org/#/builders/26/builds/458

Comment 3 Jonathan Bedard 2020-02-10 14:38:10 PST

Comment on attachment 390296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390296&action=review

> Tools/BuildSlaveSupport/ews-build/factories.py:223
> +        # TODO: add build-step to commit to repository here

Is this really useful to land without the commit step? Not that the code is bad, just seems not useful to land right now.

Is there a reason we want this landed now?

Comment 4 Aakash Jain 2020-03-21 03:10:06 PDT

Implemented it in a different manner, by dynamically adding these steps wherever required. e.g.: Bug 209334 and Bug 209226