Bug 207471

Summary: [WPE] Use custom theme style to render buttons
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 207379    
Bug Blocks: 207686    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-02-10 09:31:58 PST
Push, check and radio buttons.
Attachments
Patch (16.64 KB, patch)
2020-02-10 09:38 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-02-10 09:38:40 PST
Created attachment 390256 [details] Patch
Adrian Perez
Comment 2 2020-02-17 01:43:48 PST
Comment on attachment 390256 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390256&action=review I left just a small comment, otherwise LGTM :) > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:54 > +static const int menuListButtonBorderSize = 1; // Keep in sync with buttonBorderSize in Theme. I would also add a similar comment inside “ThemeWPE.cpp” warning “Keep in sync with menuListButtonBorderSize in RenderTheme” so no matter which file one is editing, there's always a note to ensure that the other one is kept in sync =)
Carlos Garcia Campos
Comment 3 2020-02-17 02:13:08 PST
Committed r256726: <https://trac.webkit.org/changeset/256726>
Note You need to log in before you can comment on or make changes to this bug.