Bug 207459

Summary: [watchOS] Notification listener is never unregistered
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mjs: review+
Patch none

Description Per Arne Vollan 2020-02-10 07:16:21 PST 
On watchOS, the backlight changed notification is registered in WebProcessPool::registerNotificationObservers(), but not unregistered in WebProcessPool::unregisterNotificationObservers().
Comment 1 Per Arne Vollan 2020-02-10 07:17:29 PST 
rdar://problem/58923393
Comment 2 Per Arne Vollan 2020-02-10 07:22:15 PST 
Created attachment 390250 [details]
Patch
Comment 3 Maciej Stachowiak 2020-02-10 11:14:22 PST 
Comment on attachment 390250 [details]
Patch

Maybe worth making an API test in case they are run there some day, or in case we make this mistake on another platform?

Code change looks fine but I suggest adding a test.
Comment 4 Per Arne Vollan 2020-02-10 12:51:11 PST 
(In reply to Maciej Stachowiak from comment #3)
> Comment on attachment 390250 [details]
> Patch
> 
> Maybe worth making an API test in case they are run there some day, or in
> case we make this mistake on another platform?
> 
> Code change looks fine but I suggest adding a test.

Thanks for reviewing! I will look into adding a test.
Comment 5 Per Arne Vollan 2020-02-10 14:46:39 PST 
Created attachment 390297 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-10 15:49:20 PST 
Comment on attachment 390297 [details]
Patch

Clearing flags on attachment: 390297

Committed r256225: <https://trac.webkit.org/changeset/256225>