Bug 207429

Summary:

[LFC][BFC] Box::isFloatAvoider should not check for isFloatingPositioned()

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description zalan 2020-02-08 12:02:39 PST

it already checks for establishesBlockFormattingContext() (and floats do establish BFCs)

Comment 1 Radar WebKit Bug Importer 2020-02-08 12:03:09 PST

<rdar://problem/59288204>

Comment 2 zalan 2020-02-08 12:06:29 PST

Created attachment 390175 [details]
Patch

Comment 3 WebKit Commit Bot 2020-02-08 13:54:27 PST

The commit-queue encountered the following flaky tests while processing attachment 390175 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.

Comment 4 WebKit Commit Bot 2020-02-08 13:55:03 PST

Comment on attachment 390175 [details]
Patch

Clearing flags on attachment: 390175

Committed r256094: <https://trac.webkit.org/changeset/256094>

Comment 5 WebKit Commit Bot 2020-02-08 13:55:04 PST

All reviewed patches have been landed.  Closing bug.