| Summary: | Harden HashTable IPC decoders | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2020-02-07 16:07:15 PST
Created attachment 390142 [details]
Patch
Created attachment 390144 [details]
Patch
Comment on attachment 390144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390144&action=review > Source/WebKit/Platform/IPC/ArgumentCoders.h:392 > + if (UNLIKELY(!HashMapType::isValidValue(*key) || !hashMap.add(WTFMove(*key), WTFMove(*value)).isNewEntry)) { I thought it was isValidKey() for HashMap and isValidValue() for HashSet? > Source/WebKit/Platform/IPC/ArgumentCoders.h:447 > + if (UNLIKELY(!HashSetType::isValidKey(*key) || !hashSet.add(WTFMove(*key)).isNewEntry)) { ditto. Created attachment 390145 [details]
Patch
Comment on attachment 390145 [details]
Patch
r=me
|