Bug 207405

Summary: TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jonathan Bedard 2020-02-07 13:57:14 PST 
Our ActionSheet tests test behavior not applicable to Catalyst. Disable these tests on Catalyst.
Comment 1 Jonathan Bedard 2020-02-07 13:59:44 PST 
Created attachment 390119 [details]
Patch
Comment 2 Wenson Hsieh 2020-02-07 14:38:22 PST 
Comment on attachment 390119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390119&action=review

> Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:29
> +#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)

You should update the corresponding #endif as well.
Comment 3 Jonathan Bedard 2020-02-07 14:48:24 PST 
Created attachment 390128 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-02-07 15:38:23 PST 
Comment on attachment 390128 [details]
Patch for landing

Clearing flags on attachment: 390128

Committed r256074: <https://trac.webkit.org/changeset/256074>
Comment 5 WebKit Commit Bot 2020-02-07 15:38:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-07 15:39:18 PST 
<rdar://problem/59276605>