| Summary: | Handle deprecated APIs in WKImagePreviewViewController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, commit-queue, krollin, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jonathan Bedard
2020-02-07 12:06:03 PST
Created attachment 390114 [details]
Patch
Comment on attachment 390114 [details] Patch Clearing flags on attachment: 390114 Committed r256057: <https://trac.webkit.org/changeset/256057> All reviewed patches have been landed. Closing bug. Comment on attachment 390114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review > Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98 > +ALLOW_DEPRECATED_DECLARATIONS_BEGIN > ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN > - (NSArray<UIPreviewAction *> *)previewActionItems Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration. Comment on attachment 390114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390114&action=review >> Source/WebKit/UIProcess/WKImagePreviewViewController.mm:98 >> - (NSArray<UIPreviewAction *> *)previewActionItems > > Why is this right? Surely there is no need for ALLOW_DEPRECATED_DECLARATIONS_BEGIN around previewActionItems, because it's not even a declaration. It could definitely be tighter (it's about things inside the method body), but also doesn't really matter? Usually these annotate code that needs rework. If we don't care about precisely identifying such code, it would be easier to just disable deprecation warnings for the whole project. Or are you saying that everything between these lines needs to be reworked? (In reply to Alexey Proskuryakov from comment #7) > Usually these annotate code that needs rework. If we don't care about > precisely identifying such code, it would be easier to just disable > deprecation warnings for the whole project. > > Or are you saying that everything between these lines needs to be reworked? More than half, anyway. (In reply to Alexey Proskuryakov from comment #7) > Usually these annotate code that needs rework. If we don't care about > precisely identifying such code, it would be easier to just disable > deprecation warnings for the whole project. Also, it's ... 10 lines. This seems a little unnecessarily melodramatic :) Excuses. |