Bug 207388

Summary: [Win] Two FileSystem API tests fail
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, don.olmstead, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Stephan Szabo 2020-02-07 09:34:08 PST 
FileSystemTest.UnicodeDirectoryName fails because directoryName takes off \ but not / from the ends of paths causing a mismatch with the expected result. As PathFindFileName appears to stop at either, we probably should remove either from the end.

FileSystemTest.GetFileMetadataSymlink has two issues.

* First, creating a symlink appears to be returning the wrong truth value for success because CreateSymbolicLinkW returns zero on failure and non-zero on success (https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createsymboliclinkw).

* Second, GetFinalPathNameByHandleW with VOLUME_NAME_NT appears to return a path that FindFirstFileW fails to open (I get paths starting with something like "\Device\HarddiskVolume6\").
Comment 1 Stephan Szabo 2020-02-07 09:46:38 PST 
Created attachment 390092 [details]
Patch
Comment 2 WebKit Commit Bot 2020-02-07 14:29:22 PST 
Comment on attachment 390092 [details]
Patch

Clearing flags on attachment: 390092

Committed r256063: <https://trac.webkit.org/changeset/256063>
Comment 3 WebKit Commit Bot 2020-02-07 14:29:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-07 14:30:19 PST 
<rdar://problem/59273901>