| Summary: | [ews] add commit-queue build step to close the bug | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206536 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 201934 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-02-07 09:28:03 PST
Created attachment 390088 [details]
Patch
Comment on attachment 390088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390088&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:562 > + self._addToLog('stdio', 'bug_id build property not found.\n') Seems like we're duplicating this one a lot. Maybe add a 'has_bug_id' step to BugzillaMixin in a separate patch? Comment on attachment 390088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390088&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:562 >> + self._addToLog('stdio', 'bug_id build property not found.\n') > > Seems like we're duplicating this one a lot. Maybe add a 'has_bug_id' step to BugzillaMixin in a separate patch? I am actually not sure if we should even have this additional check or not, theoretically this shouldn't ever be hit. ews django app does send both bug_id and patch_id with the patch to buildbot. Also, if the patch_id is missing, ValidatePatch step will halt the build. For bug_id, it's theoretically possible to have missing bug_id though (e.g.: for security patch, if ews django app didn't send the bug_id for some reason). However, it's possible for someone to define a new factory and add this build-step in some other order/manner, so it's probably fine to have this additional check. Committed r256031: <https://trac.webkit.org/changeset/256031> |