| Summary: | [WPE] Use custom theme style to render text fields | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, aperez, bugs-noreply, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ryuan.choi, sergio | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=207328 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 207471 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2020-02-07 02:20:41 PST
Created attachment 390069 [details]
Patch
Comment on attachment 390069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review Patch LGTM with a small unimportant nit :] > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43 > +static const int textFieldBorderSize = 1; Nit: I would use “unsigned” here, as it does not make sense to allow negative values for a border. Comment on attachment 390069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390069&action=review >> Source/WebCore/platform/wpe/RenderThemeWPE.cpp:43 >> +static const int textFieldBorderSize = 1; > > Nit: I would use “unsigned” here, as it does not make sense to allow > negative values for a border. It's used with negative value for .inflate(), that's why I changed it to int. > Source/WebCore/platform/wpe/RenderThemeWPE.cpp:128 > + fieldRect.inflate(-borderSize); Here. Committed r256724: <https://trac.webkit.org/changeset/256724> |