Bug 207375

Summary: [WebCrypto] Add tests for AES-CTR counter overflow
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: WebCore Misc.Assignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED WONTFIX    
Severity: Normal CC: jiewen_tan, tomoki.imai
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207238
https://bugs.webkit.org/show_bug.cgi?id=207176
Attachments:
Description Flags
Patch none

Description Yoshiaki Jitsukawa 2020-02-06 21:35:13 PST 
Add tests for AES-CTR counter overflow in advance so that we can test new AES-CTR implementation.

Related bugs:
 Bug 207238
 Bug 207176
Comment 1 Yoshiaki Jitsukawa 2020-02-06 21:41:47 PST 
Created attachment 390055 [details]
Patch
Comment 2 Jiewen Tan 2020-02-07 12:06:25 PST 
(In reply to Yoshiaki Jitsukawa from comment #0)
> Add tests for AES-CTR counter overflow in advance so that we can test new
> AES-CTR implementation.
> 
> Related bugs:
>  Bug 207238
>  Bug 207176

You can use 'See Also' over the top right side to relate bugs. Also, 'Depends on' or 'Blocks' if bugs have dependency.
Comment 3 Jiewen Tan 2020-02-07 12:28:47 PST 
Comment on attachment 390055 [details]
Patch

The test looks solid. However, it seems the same as the one you wrote in Bug 207238.
Comment 4 Yoshiaki Jitsukawa 2020-02-09 17:42:08 PST 
(In reply to Jiewen Tan from comment #2)
> (In reply to Yoshiaki Jitsukawa from comment #0)
> > Add tests for AES-CTR counter overflow in advance so that we can test new
> > AES-CTR implementation.
> > 
> > Related bugs:
> >  Bug 207238
> >  Bug 207176
> 
> You can use 'See Also' over the top right side to relate bugs. Also,
> 'Depends on' or 'Blocks' if bugs have dependency.

Oh, I wasn't aware of 'See Also'. Thank you.
Comment 5 Yoshiaki Jitsukawa 2020-02-09 18:03:01 PST 
(In reply to Jiewen Tan from comment #3)
> Comment on attachment 390055 [details]
> Patch
> 
> The test looks solid. However, it seems the same as the one you wrote in Bug
> 207238.

If this patch is OK to land, let me update the patch in Bug 207238 to remove duplicated test part afterward. Otherwise let me close this ticket and continue on Bug 207238. Either is fine to me.
Comment 6 Jiewen Tan 2020-02-10 11:13:20 PST 
(In reply to Yoshiaki Jitsukawa from comment #5)
> (In reply to Jiewen Tan from comment #3)
> > Comment on attachment 390055 [details]
> > Patch
> > 
> > The test looks solid. However, it seems the same as the one you wrote in Bug
> > 207238.
> 
> If this patch is OK to land, let me update the patch in Bug 207238 to remove
> duplicated test part afterward. Otherwise let me close this ticket and
> continue on Bug 207238. Either is fine to me.

I think it is better for you to add these tests to Bug 207238.
Comment 7 Yoshiaki Jitsukawa 2020-02-11 14:09:08 PST 
(In reply to Jiewen Tan from comment #6)
> I think it is better for you to add these tests to Bug 207238.

OK, I'll do so. Thank you.