Bug 207367

Summary: Build entitlements into GPU Process
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, eric.carlson, ggaren, krollin, pvollan, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2020-02-06 16:03:20 PST 
Update the build rules to embed the correct entitlements in the new GPU Process.
Comment 1 Brent Fulgham 2020-02-06 16:03:59 PST 
<rdar://problem/59208411>
Comment 2 Brent Fulgham 2020-02-06 16:06:50 PST 
Created attachment 390019 [details]
Patch
Comment 3 Geoffrey Garen 2020-02-06 16:14:27 PST 
Comment on attachment 390019 [details]
Patch

r=me
Comment 4 Alexey Proskuryakov 2020-02-06 17:40:13 PST 
Comment on attachment 390019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390019&action=review

> Source/WebKit/Scripts/process-entitlements.sh:26
> +    if [[ "${WK_USE_RESTRICTED_ENTITLEMENTS}" == YES ]]

Will there be any more functionality unavailable in open source builds than there is today?

> Source/WebKit/Scripts/process-entitlements.sh:28
> +        if (( "${TARGET_MAC_OS_X_VERSION_MAJOR}" >= 101400 ))

Why is this version check necessary?
Comment 5 WebKit Commit Bot 2020-02-06 18:22:01 PST 
The commit-queue encountered the following flaky tests while processing attachment 390019 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-02-06 18:22:07 PST 
The commit-queue encountered the following flaky tests while processing attachment 390019 [details]:

imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-02-06 19:26:50 PST 
The commit-queue encountered the following flaky tests while processing attachment 390019 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-02-06 19:27:28 PST 
Comment on attachment 390019 [details]
Patch

Clearing flags on attachment: 390019

Committed r256004: <https://trac.webkit.org/changeset/256004>
Comment 9 WebKit Commit Bot 2020-02-06 19:27:30 PST 
All reviewed patches have been landed.  Closing bug.