| Summary: | Add slot based test for the accelerated animations freezing bug (201048) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Animations | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, graouts, rniwa, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=204805 https://bugs.webkit.org/show_bug.cgi?id=201048 |
||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2020-02-06 14:50:52 PST
Created attachment 390004 [details]
patch
Comment on attachment 390004 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:52 > + // Put a named slot and assign an element to it. These comments seem unnecessary? I can see that from the code. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:60 > + // Create another named slot and assign another element to it. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:64 > + // Start animation in the seconds slot. Ditto. > LayoutTests/webanimations/accelerated-animation-slot-invalidation.html:79 > + // Wait until animation has progressed some before snapshotting the test result. Whereas this explanation is kind of useful. > These comments seem unnecessary? I can see that from the code.
They were in the original test, I suppose the author found them helpful.
(In reply to Antti Koivisto from comment #3) > > These comments seem unnecessary? I can see that from the code. > > They were in the original test, I suppose the author found them helpful. Was it imported from somewhere?? If so, we need to give a credit. Comment on attachment 390004 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390004&action=review > LayoutTests/ChangeLog:10 > + Based on the original test by Tim Guan-tin Chien. Ah, I missed this line. Comment on attachment 390004 [details] patch Clearing flags on attachment: 390004 Committed r255996: <https://trac.webkit.org/changeset/255996> All reviewed patches have been landed. Closing bug. |