Bug 207351

Summary: Cleanup and promote WKContentWorld and its clients in WKWebView
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit APIAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch commit-queue: commit-queue-

Brady Eidson
Reported 2020-02-06 13:55:46 PST
Cleanup and promote WKContentWorld and its clients in WKWebView
Attachments
Patch (64.04 KB, patch)
2020-02-06 14:06 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (1.17 KB, patch)
2020-02-07 12:55 PST, Brady Eidson 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-02-06 14:06:36 PST
Created attachment 389993 [details] Patch
Alex Christensen
Comment 2 2020-02-06 14:16:01 PST
Comment on attachment 389993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389993&action=review > Source/WebKit/Shared/Cocoa/APIObject.mm:-351 > - wrapper = [_WKContentWorld alloc]; There were no clients of this old class, right? Otherwise we would need a wrapper to keep binary compatibility. > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:828 > +- (void)callAsyncJavaScript:(NSString *)javaScriptString arguments:(NSDictionary<NSString *, id> *)arguments inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^)(id, NSError *error))completionHandler The JavaScript is not necessarily Async. Could we remove that? If not, do we want to write out Asynchronous?
Brady Eidson
Comment 3 2020-02-06 14:21:44 PST
(In reply to Alex Christensen from comment #2) > Comment on attachment 389993 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389993&action=review > > > Source/WebKit/Shared/Cocoa/APIObject.mm:-351 > > - wrapper = [_WKContentWorld alloc]; > > There were no clients of this old class, right? Otherwise we would need a > wrapper to keep binary compatibility. No clients, correct. > > > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:828 > > +- (void)callAsyncJavaScript:(NSString *)javaScriptString arguments:(NSDictionary<NSString *, id> *)arguments inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^)(id, NSError *error))completionHandler > > The JavaScript is not necessarily Async. Could we remove that? > If not, do we want to write out Asynchronous? This name is what internal discussion settled on.
WebKit Commit Bot
Comment 4 2020-02-06 18:26:41 PST
Comment on attachment 389993 [details] Patch Clearing flags on attachment: 389993 Committed r255998: <https://trac.webkit.org/changeset/255998>
WebKit Commit Bot
Comment 5 2020-02-06 18:26:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-06 18:27:11 PST
<rdar://problem/59247330>
Alex Christensen
Comment 7 2020-02-07 10:39:08 PST
Comment on attachment 389993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389993&action=review > Source/WebKit/ChangeLog:17 > + * UIProcess/API/Cocoa/WKContentWorld.h: Renamed from Source/WebKit/UIProcess/API/Cocoa/_WKContentWorld.h. You should add this to WebKit.h.
Brady Eidson
Comment 8 2020-02-07 12:55:29 PST
Reopening to attach new patch.
Brady Eidson
Comment 9 2020-02-07 12:55:30 PST
Created attachment 390116 [details] Patch
WebKit Commit Bot
Comment 10 2020-02-07 14:18:46 PST
Comment on attachment 390116 [details] Patch Rejecting attachment 390116 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 390116, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/13318758
Alex Christensen
Comment 11 2020-02-11 09:48:28 PST
http://trac.webkit.org/r256312
Note You need to log in before you can comment on or make changes to this bug.