Bug 207329

Summary: Mandate UUID version 4 for mDNS ICE candidates
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Fix according comments none

youenn fablet
Reported 2020-02-06 06:03:49 PST
Mandate UUID version 4 for mDNS ICE candidates
Attachments
Patch (7.24 KB, patch)
2020-02-06 06:09 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.26 KB, patch)
2020-02-06 06:46 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.04 KB, patch)
2020-02-06 23:44 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fix according comments (1.87 KB, patch)
2020-02-07 06:28 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-06 06:05:54 PST
<rdar://problem/59221606>
youenn fablet
Comment 2 2020-02-06 06:09:16 PST
Created attachment 389944 [details] Patch
youenn fablet
Comment 3 2020-02-06 06:46:08 PST
Created attachment 389950 [details] Patch
Eric Carlson
Comment 4 2020-02-06 06:47:04 PST
Comment on attachment 389950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389950&action=review > Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:306 > static String extractIPAddres(const String& sdp) s/extractIPAddres/extractIPAddress/
youenn fablet
Comment 5 2020-02-06 07:46:41 PST
(In reply to Eric Carlson from comment #4) > Comment on attachment 389950 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389950&action=review > > > Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:306 > > static String extractIPAddres(const String& sdp) > > s/extractIPAddres/extractIPAddress/ Will fix it.
youenn fablet
Comment 6 2020-02-06 23:44:47 PST
Created attachment 390059 [details] Patch for landing
WebKit Commit Bot
Comment 7 2020-02-07 02:42:03 PST
The commit-queue encountered the following flaky tests while processing attachment 390059 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-02-07 02:42:42 PST
Comment on attachment 390059 [details] Patch for landing Clearing flags on attachment: 390059 Committed r256016: <https://trac.webkit.org/changeset/256016>
WebKit Commit Bot
Comment 9 2020-02-07 02:42:44 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 10 2020-02-07 05:31:17 PST
Comment on attachment 390059 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=390059&action=review > Source/WTF/wtf/UUID.cpp:84 > +static inline bool isHexadecimalCharacter(UChar character) Should use isASCIIHexDigit from <wtf/ASCIICType.h> rather than writing a new one.
youenn fablet
Comment 11 2020-02-07 06:28:08 PST
Reopening to attach new patch.
youenn fablet
Comment 12 2020-02-07 06:28:11 PST
Created attachment 390078 [details] Fix according comments
WebKit Commit Bot
Comment 13 2020-02-07 10:09:33 PST
The commit-queue encountered the following flaky tests while processing attachment 390078 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2020-02-07 10:10:09 PST
Comment on attachment 390078 [details] Fix according comments Clearing flags on attachment: 390078 Committed r256030: <https://trac.webkit.org/changeset/256030>
WebKit Commit Bot
Comment 15 2020-02-07 10:10:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.