Bug 207323

Summary:	WEBCORE_TESTSUPPORT_EXPORT shouldn't be defined for compiling WebCore to avoid misuse
Product:	WebKit	Reporter:	Fujii Hironori <Hironori.Fujii>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	darin
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Fujii Hironori 2020-02-05 23:00:06 PST

WEBCORE_TESTSUPPORT_EXPORT shouldn't be defined for compiling WebCore to avoid misuse

As r252166 states, WEBCORE_TESTSUPPORT_EXPORT is used only for
WebCoreTestSupport module, but for WebCore module.

However, WEBCORE_TESTSUPPORT_EXPORT can be used
interchangeably with WEBCORE_EXPORT in almost all ports becasue
both macro definitions are exactly same, __attribute__((visibility("default"))).
Unfortunately, Windows port isn't the case.

Comment 1 Fujii Hironori 2020-02-05 23:20:48 PST

WEBCORE_TESTSUPPORT_EXPORT was added by r180653 (Bug 141734). Its ChangeLog also says:

>    * testing/Internals.h: Use WEBCORE_TESTSUPPORT_EXPORT for things that
>    are supposed to be exported by WebCoreTestSupport, not WebCore.
>    * testing/js/WebCoreTestSupport.cpp: Add missing #include needed by