Bug 207322

Summary: Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED MOVED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, jonlee, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207422
Attachments:
Description Flags
Patch none

Description Devin Rousso 2020-02-05 20:30:20 PST 
# STEPS TO REPRODUCE:
1. inspect any page
2. search for "div" via the Search Tab
 => as soon as results start appearing in the Search Tab, Web Inspector will instantly switch to the Elements Tab and select the node that matches the search result
Comment 1 Devin Rousso 2020-02-05 20:33:39 PST 
Created attachment 389934 [details]
Patch
Comment 2 BJ Burg 2020-02-06 13:35:16 PST 
Comment on attachment 389934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +        such, we should update it's position in the `_recentTabContentViews` list so that we can use

So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ?
Comment 3 Devin Rousso 2020-02-06 13:43:28 PST 
Comment on attachment 389934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review

>> Source/WebInspectorUI/ChangeLog:14
>> +        such, we should update it's position in the `_recentTabContentViews` list so that we can use
> 
> So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ?

Yup!
Comment 4 WebKit Commit Bot 2020-02-06 14:15:40 PST 
Comment on attachment 389934 [details]
Patch

Clearing flags on attachment: 389934

Committed r255980: <https://trac.webkit.org/changeset/255980>
Comment 5 WebKit Commit Bot 2020-02-06 14:15:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-02-06 14:16:15 PST 
<rdar://problem/59236869>
Comment 7 Jon Lee 2020-02-07 20:23:31 PST 
Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422.
Comment 8 Devin Rousso 2020-03-02 16:54:58 PST 
This will be resolved by <https://webkit.org/b/207317>.