| Summary: | [Cairo] Do not use old-style GNU field initializers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
| Component: | WebCore Misc. | Assignee: | Adrian Perez <aperez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, cgarcia, clopez, commit-queue, simon.fraser, webkit-bug-importer, zan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 389899 [details]
Patch
Comment on attachment 389899 [details] Patch Clearing flags on attachment: 389899 Committed r255911: <https://trac.webkit.org/changeset/255911> All reviewed patches have been landed. Closing bug. |
Clang is already warning about using struct foo value = { member: 42 }; instead the standard syntax for field initializers should be used: struct foo value = { .member = 42 }; Log of warnings generated by Clang follows. --- ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:120:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleStart)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:121:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleStart)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:124:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleStart)) - f * (r * sin(angleStart)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:125:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleStart)) + f * (r * cos(angleStart)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:128:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleEnd)) + f * (r * sin(angleEnd)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:129:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleEnd)) - f * (r * cos(angleEnd)) ^~ .y = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:132:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] x: cx + (r * cos(angleEnd)), ^~ .x = ../Source/WebCore/platform/graphics/cairo/GradientCairo.cpp:133:9: warning: use of GNU old-style field designator extension [-Wgnu-designator] y: cy + (r * sin(angleEnd)) ^~ .y = 8 warnings generated.