Bug 207304

Summary: resulsdbpy: Fix unit tests
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201928
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2020-02-05 15:40:00 PST
We have a few broken unit tests when using actual Cassandra (I tend to avoid running these tests because they are much more expensive then the mock versions)
Comment 1 Jonathan Bedard 2020-02-05 15:51:13 PST
Created attachment 389891 [details]
Patch
Comment 2 Jonathan Bedard 2020-02-05 15:52:35 PST
100% testing code, none of this is actually serving content on results.webkit.org
Comment 3 Aakash Jain 2020-02-05 15:57:54 PST
This reminds me that we should run these tests in EWS. <rdar://problem/55109441>
Comment 4 Jonathan Bedard 2020-02-05 16:01:51 PST
(In reply to Aakash Jain from comment #3)
> This reminds me that we should run these tests in EWS.
> <rdar://problem/55109441>

Yes, I was going to do that next, actually. We need some Pip packages on our EWS machine for it.
Comment 5 WebKit Commit Bot 2020-02-05 17:13:52 PST
Comment on attachment 389891 [details]
Patch

Clearing flags on attachment: 389891

Committed r255883: <https://trac.webkit.org/changeset/255883>
Comment 6 WebKit Commit Bot 2020-02-05 17:13:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-05 17:14:16 PST
<rdar://problem/59208735>