Bug 207274

Summary: ASSERTION FAILED: entry.clipData.clippingLayer->isComposited() on compositing/shared-backing/sharing-child-contributes-to-overlap.html
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: CompositingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: iOS 13   
Attachments:
Description Flags
Update Test Expectations none

Description Jason Lawrence 2020-02-05 09:57:33 PST 
compositing/shared-backing/sharing-child-contributes-to-overlap.html

Description:
This test is flaky crashing on iPadOS wk2 debug.

History:
https://results.webkit.org/?suite=layout-tests&test=compositing%2Fshared-backing%2Fsharing-child-contributes-to-overlap.html&platform=ios&model=iPad%20(5th%20generation)&model=iPad%20Pro%20(9.7-inch)&style=debug&limit=50000

Crash log:
No crash log found for com.apple.WebKit.WebContent.Development:70943.

stdout:

stderr:
ASSERTION FAILED: entry.clipData.clippingLayer->isComposited()
./rendering/RenderLayerCompositor.cpp(4580) : WebCore::ScrollingNodeID WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole(WebCore::RenderLayer &, WebCore::ScrollingTreeState &, OptionSet<WebCore::RenderLayerCompositor::ScrollingNodeChangeFlags>)
1   0x59308e409 WTFCrash
2   0x59846a71b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x59c018ceb WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole(WebCore::RenderLayer&, WebCore::ScrollingTreeState&, WTF::OptionSet<WebCore::RenderLayerCompositor::ScrollingNodeChangeFlags>)
4   0x59c00e45c WebCore::RenderLayerCompositor::updateScrollCoordinationForLayer(WebCore::RenderLayer&, WebCore::RenderLayer const*, WebCore::ScrollingTreeState&, WTF::OptionSet<WebCore::RenderLayerCompositor::ScrollingNodeChangeFlags>)
5   0x59c00b0a9 WebCore::RenderLayerCompositor::updateBackingAndHierarchy(WebCore::RenderLayer&, WTF::Vector<WTF::Ref<WebCore::GraphicsLayer, WTF::DumbPtrTraits<WebCore::GraphicsLayer> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::RenderLayerCompositor::UpdateBackingTraversalState&, WebCore::ScrollingTreeState&, WTF::OptionSet<WebCore::RenderLayerCompositor::UpdateLevel>)
6   0x59c00b4aa WebCore::RenderLayerCompositor::updateBackingAndHierarchy(WebCore::RenderLayer&, WTF::Vector<WTF::Ref<WebCore::GraphicsLayer, WTF::DumbPtrTraits<WebCore::GraphicsLayer> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::RenderLayerCompositor::UpdateBackingTraversalState&, WebCore::ScrollingTreeState&, WTF::OptionSet<WebCore::RenderLayerCompositor::UpdateLevel>)
7   0x59c00b4aa WebCore::RenderLayerCompositor::updateBackingAndHierarchy(WebCore::RenderLayer&, WTF::Vector<WTF::Ref<WebCore::GraphicsLayer, WTF::DumbPtrTraits<WebCore::GraphicsLayer> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::RenderLayerCompositor::UpdateBackingTraversalState&, WebCore::ScrollingTreeState&, WTF::OptionSet<WebCore::RenderLayerCompositor::UpdateLevel>)
8   0x59c007a76 WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*)
9   0x59b65c6e3 WebCore::FrameView::updateCompositingLayersAfterLayout()
10  0x59b65f014 WebCore::FrameView::didLayout(WTF::WeakPtr<WebCore::RenderElement>)
11  0x59b6a7f0b WebCore::FrameViewLayoutContext::layout()
12  0x59b63a61c WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
13  0x59b6cf89c WebCore::Page::layoutIfNeeded()
14  0x59b6cf94a WebCore::Page::updateRendering()
15  0x58163fc41 WebKit::WebPage::updateRendering()
16  0x58032a622 WebKit::RemoteLayerTreeDrawingArea::flushLayers()
17  0x5803341e1 decltype(*(std::__1::forward<WebKit::RemoteLayerTreeDrawingArea*&>(fp0)).*fp()) std::__1::__invoke<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&, void>(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*&)
18  0x580334160 std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, 0ul, std::__1::tuple<> >(void (WebKit::RemoteLayerTreeDrawingArea::*&)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&)
19  0x58033410c std::__1::__bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::RemoteLayerTreeDrawingArea::*)(), std::__1::tuple<WebKit::RemoteLayerTreeDrawingArea*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>::operator()<>()
20  0x5803340a9 WTF::Detail::CallableWrapper<std::__1::__bind<void (WebKit::RemoteLayerTreeDrawingArea::*&)(), WebKit::RemoteLayerTreeDrawingArea*>, void>::call()
21  0x5801882da WTF::Function<void ()>::operator()() const
22  0x580330079 WebCore::Timer::fired()
23  0x59b8ff3aa WebCore::ThreadTimers::sharedTimerFiredInternal()
24  0x59b908011 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const
25  0x59b907fc9 WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call()
26  0x59847e9ca WTF::Function<void ()>::operator()() const
27  0x59b8c4247 WebCore::MainThreadSharedTimer::fired()
28  0x59b966b06 WebCore::timerFired(__CFRunLoopTimer*, void*)
29  0x58afa3b94 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
30  0x58afa3882 __CFRunLoopDoTimer
31  0x58afa2eda __CFRunLoopDoTimers
LEAK: 2 WebPageProxy
Comment 1 Radar WebKit Bug Importer 2020-02-05 09:57:57 PST 
<rdar://problem/59191840>
Comment 2 Jason Lawrence 2020-02-05 10:04:57 PST 
Created attachment 389823 [details]
Update Test Expectations
Comment 3 Truitt Savell 2020-02-05 10:24:42 PST 
Comment on attachment 389823 [details]
Update Test Expectations

Clearing flags on attachment: 389823

Committed r255828: <https://trac.webkit.org/changeset/255828>
Comment 4 Ryan Haddad 2020-04-08 23:02:01 PDT 
The test is consistently passing now. Removed expectation in r259782.