Bug 207227

Summary: Non-unified build fixes early February 2020 edition
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, benjamin, cdumez, cfleizach, cgarcia, clopez, cmarcelo, commit-queue, dbates, dmazzoni, don.olmstead, ews-watchlist, hi, jcraig, jdiggs, joepeck, keith_miller, mark.lam, msaboff, saam, samuel_white, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Adrian Perez 2020-02-04 14:21:44 PST 
We'll keep having issues now and then until I get round to
continue work on #206737 ¬_¬
Comment 1 Adrian Perez 2020-02-04 14:27:04 PST 
Created attachment 389708 [details]
Patch
Comment 2 Don Olmstead 2020-02-04 14:29:50 PST 
Comment on attachment 389708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389708&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Non-unified build fixes early January 2020 edition

We're in February
Comment 3 Adrian Perez 2020-02-04 14:32:06 PST 
(In reply to Don Olmstead from comment #2)
> Comment on attachment 389708 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=389708&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        Non-unified build fixes early January 2020 edition
> 
> We're in February

So true 🤦‍♂️️
Comment 4 Don Olmstead 2020-02-04 15:14:00 PST 
Comment on attachment 389708 [details]
Patch

I feel like these build fixes can be unreviewed. Going to r+ cause its fine but cq- because the Changelogs have the previous title
Comment 5 Adrian Perez 2020-02-04 15:26:10 PST 
Created attachment 389724 [details]
Patch for landing
Comment 6 Adrian Perez 2020-02-04 15:27:21 PST 
(In reply to Don Olmstead from comment #4)
> Comment on attachment 389708 [details]
> Patch
> 
> I feel like these build fixes can be unreviewed. Going to r+ cause its fine
> but cq- because the Changelogs have the previous title

Sure, I will do them as unreviewed build fixes from now on unless there
is something that I am not 100% sure about :)

Thanks!
Comment 7 WebKit Commit Bot 2020-02-04 16:09:46 PST 
Comment on attachment 389724 [details]
Patch for landing

Clearing flags on attachment: 389724

Committed r255711: <https://trac.webkit.org/changeset/255711>
Comment 8 WebKit Commit Bot 2020-02-04 16:09:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-02-04 16:10:19 PST 
<rdar://problem/59170022>