| Summary: | Regression (~r252261): [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jason Lawrence <Lawrence.j> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | inspector-bugzilla-changes, jacob_uphoff, joepeck, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Mac | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=155312 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jason Lawrence
2020-02-04 09:59:13 PST
Created attachment 389685 [details]
Update Test Expectations
Here's a diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/heap/getPreview-actual.txt
@@ -29,23 +29,12 @@
OBJECT PREVIEW: {
"type": "object",
"description": "Map",
- "lossless": true,
- "subtype": "map",
- "overflow": false,
- "properties": [],
- "size": 1,
- "entries": [
+ "lossless": false,
+ "properties": [
{
- "key": {
- "type": "string",
- "description": "key",
- "lossless": true
- },
- "value": {
- "type": "string",
- "description": "value",
- "lossless": true
- }
+ "name": "Symbol(Symbol.toStringTag)",
+ "type": "string",
+ "value": "Map"
}
]
}
Created attachment 389687 [details]
Update Test Expectations
Comment on attachment 389687 [details] Update Test Expectations Clearing flags on attachment: 389687 Committed r255690: <https://trac.webkit.org/changeset/255690> I ran this test in iterations x5000 and did not reproduce a failure. I was able to reproduce this issue with 255856 using the following command. run-webkit-tests --root xxx inspector/heap/getPreview.html --iterations 5000 -f --exit-after-n-failures 5 -g --force --time-out-ms 10000 [15/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [17/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [18/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [22/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) [23/5000] inspector/heap/getPreview.html failed unexpectedly (text diff) Exiting early after 5 failures. 20 tests run. 15 tests ran as expected, 5 didn't (4980 didn't run): Hmm, I don't like the idea of papering over this potential issue. It sounds like a (In reply to Jason Lawrence from comment #3) > Here's a diff: > > --- > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-expected.txt > +++ > /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/ > inspector/heap/getPreview-actual.txt > @@ -29,23 +29,12 @@ > OBJECT PREVIEW: { > "type": "object", > "description": "Map", > - "lossless": true, > - "subtype": "map", > - "overflow": false, > - "properties": [], > - "size": 1, > - "entries": [ > + "lossless": false, > + "properties": [ > { > - "key": { > - "type": "string", > - "description": "key", > - "lossless": true > - }, > - "value": { > - "type": "string", > - "description": "value", > - "lossless": true > - } > + "name": "Symbol(Symbol.toStringTag)", > + "type": "string", > + "value": "Map" > } > ] > } Does this always fail this way? Can we just rebaseline? > 15 tests ran as expected, 5 didn't (4980 didn't run):
This suggests that no, we cannot rebaseline.
I don't see any failures at all before early November (roughly r252261), although there were always many timeouts. Corrected test expectations on r256174 |