Bug 207192

Summary: Check for callback being null in Notification.requestPermission
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-02-04 02:06:56 PST 
Check for callback being null in Notification.requestPermission
Comment 1 youenn fablet 2020-02-04 02:07:26 PST 
<rdar://problem/59130804>
Comment 2 youenn fablet 2020-02-04 02:09:25 PST 
Created attachment 389644 [details]
Patch
Comment 3 Chris Dumez 2020-02-04 08:07:59 PST 
Comment on attachment 389644 [details]
Patch

r=me. Not in this patch but it would be good to update this method to return a Promise as well.
Comment 4 WebKit Commit Bot 2020-02-04 08:55:20 PST 
Comment on attachment 389644 [details]
Patch

Clearing flags on attachment: 389644

Committed r255680: <https://trac.webkit.org/changeset/255680>
Comment 5 WebKit Commit Bot 2020-02-04 08:55:22 PST 
All reviewed patches have been landed.  Closing bug.