Bug 207173

Summary: Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for Landing
none
Patch none

Description Jiewen Tan 2020-02-03 18:03:43 PST 
Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide.
Comment 1 Jiewen Tan 2020-02-03 18:03:59 PST 
<rdar://problem/55669065>
Comment 2 Jiewen Tan 2020-02-03 18:16:00 PST 
Created attachment 389611 [details]
Patch
Comment 3 Jiewen Tan 2020-02-03 18:21:13 PST 
Just realized this has a dependency on Bug 207079. Will upload a rebased patch once Bug 207079 is landed.
Comment 4 Jiewen Tan 2020-02-03 22:31:10 PST 
Created attachment 389631 [details]
Patch
Comment 5 Brent Fulgham 2020-02-04 12:41:36 PST 
Comment on attachment 389631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389631&action=review

r=me

> Source/WebKit/ChangeLog:14
> +        or NSApplicationDidUnhide is received.

What happens if the application is exited? Is everything cleaned up properly with these deferred observers? (I assume so).
Comment 6 Jiewen Tan 2020-02-04 15:52:53 PST 
Comment on attachment 389631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389631&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/ChangeLog:14
>> +        or NSApplicationDidUnhide is received.
> 
> What happens if the application is exited? Is everything cleaned up properly with these deferred observers? (I assume so).

Yes, the notification center is bound to the app. However, you do remind me to examine what happens if the session is destroyed during miniaturization/hiding. I have made some changes to address that.
Comment 7 Jiewen Tan 2020-02-04 16:07:29 PST 
Created attachment 389730 [details]
Patch for Landing
Comment 8 Jiewen Tan 2020-02-04 16:16:39 PST 
Created attachment 389733 [details]
Patch
Comment 9 Jiewen Tan 2020-02-05 14:01:31 PST 
Comment on attachment 389733 [details]
Patch

The api-ios bot is taking forever. cq+ regardless.
Comment 10 WebKit Commit Bot 2020-02-05 14:49:50 PST 
Comment on attachment 389733 [details]
Patch

Clearing flags on attachment: 389733

Committed r255862: <https://trac.webkit.org/changeset/255862>
Comment 11 WebKit Commit Bot 2020-02-05 14:49:52 PST 
All reviewed patches have been landed.  Closing bug.