| Summary: | [JSC] Use PackedPtr for VariableEnvironment | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-02-03 17:53:18 PST
Created attachment 389608 [details]
Patch
Comment on attachment 389608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + * runtime/CachedTypes.cpp: > + (JSC::CachedRefPtr::encode): > + (JSC::CachedRefPtr::decode const): Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title? Comment on attachment 389608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + (JSC::CachedRefPtr::decode const): > > Your ChangeLog and title doesn't seem to include changes in CachedTypes. Is this intended to be part of this patch? If so, can you add a small blurb in the ChangeLog or update the title? Fixed. This is just because CachedTypes should handle PackedPtr since changed data structures are encoded. Committed r255659: <https://trac.webkit.org/changeset/255659> |