| Summary: | [PlayStation] Add WebKit API files | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | WebKit API | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, annulen, bfulgham, commit-queue, darin, ews-watchlist, gyuyoung.kim, rniwa, ryuan.choi, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2020-02-03 17:21:30 PST
Created attachment 389610 [details]
Patch
Created attachment 389612 [details]
Patch
Style errors are just due to the style checker not realizing in the API C directories include guards should be used. Other than that I think this is good to go. (In reply to Don Olmstead from comment #3) > Style errors are just due to the style checker not realizing in the API C > directories include guards should be used. Other than that I think this is > good to go. I think the style checker has machinery for rules like that, used for GTK bindings directories for example. We should fix that in the style checker. I personally haven’t made changes to python scripts so don’t know how to do it myself but lots of WebKit contributors know how. These rulese live in Tools/Scripts/webkitpy/style/checker.py (In reply to Darin Adler from comment #4) > (In reply to Don Olmstead from comment #3) > > Style errors are just due to the style checker not realizing in the API C > > directories include guards should be used. Other than that I think this is > > good to go. > > I think the style checker has machinery for rules like that, used for GTK > bindings directories for example. We should fix that in the style checker. I > personally haven’t made changes to python scripts so don’t know how to do it > myself but lots of WebKit contributors know how. Opened https://bugs.webkit.org/show_bug.cgi?id=207205 for the work. Other than that is this ok to land Darin? Comment on attachment 389612 [details]
Patch
Seems OK, I guess. Not sure why the empty WKView.h is a good idea.
(In reply to Darin Adler from comment #7) > Comment on attachment 389612 [details] > Patch > > Seems OK, I guess. Not sure why the empty WKView.h is a good idea. We are planning on filling it all out in subsequent patches. Comment on attachment 389612 [details] Patch Clearing flags on attachment: 389612 Committed r255685: <https://trac.webkit.org/changeset/255685> All reviewed patches have been landed. Closing bug. |