Bug 207158

Summary: [bmalloc] Add declspec support for export macros
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: bmallocAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, ggaren, gyuyoung.kim, keith_miller, mark.lam, ryuan.choi, saam, sergio, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ysuzuki: review+
Patch none

Description Don Olmstead 2020-02-03 15:32:24 PST
Currently just assuming *nix style exports.
Comment 1 Don Olmstead 2020-02-03 16:00:26 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-02-03 16:06:01 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2020-02-03 17:04:17 PST
Created attachment 389605 [details]
Patch
Comment 4 Yusuke Suzuki 2020-02-04 12:39:38 PST
Comment on attachment 389605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389605&action=review

r=me

> Source/bmalloc/bmalloc/BPlatform.h:286
> +#elif defined(__GNUC__)

Use `BCOMPILER(GCC_COMPATIBLE)` here.
Comment 5 Don Olmstead 2020-02-04 16:23:52 PST
Created attachment 389736 [details]
Patch
Comment 6 WebKit Commit Bot 2020-02-05 10:37:47 PST
Comment on attachment 389736 [details]
Patch

Clearing flags on attachment: 389736

Committed r255829: <https://trac.webkit.org/changeset/255829>
Comment 7 WebKit Commit Bot 2020-02-05 10:37:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-05 10:38:16 PST
<rdar://problem/59193595>