Bug 207154

Summary: REGRESSION (r254428): [ macOS wk1 ] inspector/canvas/recording-2d-full.html became slower, flakily times out
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: CanvasAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, hi, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=198459
https://bugs.webkit.org/show_bug.cgi?id=207145
Attachments:
Description Flags
Update Test Expectations
none
Patch none

Description Jacob Uphoff 2020-02-03 15:14:48 PST 
inspector/canvas/recording-2d-full.html

This test has been a flaky timeout for all visible history on wk1 debug 

I was not able to reproduce issue with iteration runs

History:

https://results.webkit.org/?suite=layout-tests&test=inspector%2Fcanvas%2Frecording-2d-full.html&limit=50000&platform=ios&platform=mac

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/inspector/canvas/recording-2d-full-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/inspector/canvas/recording-2d-full-actual.txt
@@ -1,3 +1,4 @@
+FAIL: Timed out waiting for notifyDone to be called
 Test that CanvasManager is able to record actions made to 2D canvas contexts.
 
 
@@ -1013,19 +1014,4 @@
       trace:
         0: (anonymous function)
         1: executeFrameFunction
-    1: width = 2
-      swizzleTypes: [Number]
-      trace:
-        0: (anonymous function)
-        1: executeFrameFunction
-  74: (duration)
-    0: height
-      trace:
-        0: (anonymous function)
-        1: executeFrameFunction
-    1: height = 2
-      swizzleTypes: [Number]
-      trace:
-        0: (anonymous function)
-        1: executeFrameFunction
Comment 1 Radar WebKit Bug Importer 2020-02-03 15:15:06 PST 
<rdar://problem/59127935>
Comment 2 Jacob Uphoff 2020-02-03 15:18:09 PST 
Created attachment 389580 [details]
Update Test Expectations
Comment 3 Ryan Haddad 2020-02-03 15:33:16 PST 
Comment on attachment 389580 [details]
Update Test Expectations

Clearing flags on attachment: 389580

Committed r255607: <https://trac.webkit.org/changeset/255607>
Comment 4 Alexey Proskuryakov 2020-02-03 23:02:17 PST 
> This test has been a flaky timeout for all visible history on wk1 debug 

You may be referring to internal test results, where this test was failing on slower bots. But there is actually a sharp start around r254428, where LFC integration patches landed.

Enabling test times on the flakiness dashboard, I see a clear performance regression. It's not visible on release bots, but it's very clear on debug, ASan and GuardMalloc. I think that it's not just more complex assertions, but more memory allocations, which is why GuardMalloc suffered more.
Comment 5 Alexey Proskuryakov 2020-02-04 10:35:30 PST 
*** Bug 207145 has been marked as a duplicate of this bug. ***
Comment 6 Devin Rousso 2020-02-05 13:30:12 PST 
Created attachment 389860 [details]
Patch
Comment 7 zalan 2020-02-05 13:47:00 PST 
you may wanna undo r255607. It's not slow anymore.
Comment 8 Alexey Proskuryakov 2020-02-05 15:09:08 PST 
And r255591 too.
Comment 9 Devin Rousso 2020-02-05 18:21:50 PST 
Comment on attachment 389860 [details]
Patch

(In reply to zalan from comment #7)
> you may wanna undo r255607. It's not slow anymore.
(In reply to Alexey Proskuryakov from comment #8)
> And r255591 too.
I think we still want these tests to be marked as slow, as they can sometimes take a while, especially in debug builds.  The payload being sent to Web Inspector is very large (it has base64 dataURLs in it), as well as heavy use of async/await.
Comment 10 zalan 2020-02-05 18:38:12 PST 
(In reply to Devin Rousso from comment #9)
> Comment on attachment 389860 [details]
> Patch
> 
> (In reply to zalan from comment #7)
> > you may wanna undo r255607. It's not slow anymore.
> (In reply to Alexey Proskuryakov from comment #8)
> > And r255591 too.
> I think we still want these tests to be marked as slow, as they can
> sometimes take a while, especially in debug builds.  The payload being sent
> to Web Inspector is very large (it has base64 dataURLs in it), as well as
> heavy use of async/await.
Could we test the bots first and make the decision based on that?
Comment 11 WebKit Commit Bot 2020-02-05 19:28:48 PST 
Comment on attachment 389860 [details]
Patch

Clearing flags on attachment: 389860

Committed r255895: <https://trac.webkit.org/changeset/255895>
Comment 12 WebKit Commit Bot 2020-02-05 19:28:50 PST 
All reviewed patches have been landed.  Closing bug.