| Summary: | NetworkProcess should be notified by UIProcess when its service worker process connection should be on | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, beidson, cdumez, commit-queue, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-02-03 08:58:44 PST
Created attachment 389523 [details]
Patch
Created attachment 389649 [details]
Patch
Created attachment 389650 [details]
Patch
Comment on attachment 389650 [details] Patch Clearing flags on attachment: 389650 Committed r255681: <https://trac.webkit.org/changeset/255681> All reviewed patches have been landed. Closing bug. Comment on attachment 389650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389650&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:1610 > + sendWithAsyncReply(Messages::WebProcess::EstablishWorkerContextConnectionToNetworkProcess { processPool().defaultPageGroup().pageGroupID(), m_serviceWorkerInformation->serviceWorkerPageProxyID, m_serviceWorkerInformation->serviceWorkerPageID, store, *m_registrableDomain, m_serviceWorkerInformation->initializationData }, [activity = m_throttler.backgroundActivity("Establish Service Worker"_s), completionHandler = WTFMove(completionHandler)]() mutable { BTW, I think it is a great fix to take a background activity here. I had identified this as an issue locally and was about to upload a patch to fix this. Previously, the service worker process could suspend *before* having finished initialization and setup a connection to the network process. I am hoping this will address the flakiness issues on the bots. |