| Summary: | run-javascriptcore-tests: Don't split binary results | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, ryanhaddad, webkit-bug-importer, zhifei_fang | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jonathan Bedard
2020-02-03 08:28:51 PST
Created attachment 389515 [details]
Patch
https://results.webkit.org/suites?suite=javascriptcore-tests demonstrates how my original approach basically failed. Comment on attachment 389515 [details]
Patch
unofficially r+, in long term we should unify all the test output format, and let those binaries generate that standard output
(In reply to Jonathan Bedard from comment #0) > Experience over the last 2 months has shown that attempting to split up results from a single JSC test binary doesn't really work. What's the issue? (In reply to Aakash Jain from comment #4) > (In reply to Jonathan Bedard from comment #0) > > Experience over the last 2 months has shown that attempting to split up results from a single JSC test binary doesn't really work. > What's the issue? We can't really do it consistently, a sub-test which fails will sometimes have a different name than when it passes and often, exception messages will be tagged as actual test names. rs=me Committed r255578: <https://trac.webkit.org/changeset/255578> |