| Summary: | MediaDevices should handle changes of iframe allow attribute value | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, mkwst, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2020-02-03 03:02:29 PST
Created attachment 389499 [details]
Patch
Comment on attachment 389499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389499&action=review > Source/WebCore/Modules/mediastream/MediaDevices.cpp:165 > + bool canAccessCamera = isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Camera, *document, LogFeaturePolicyFailure::No); > + bool canAccessMicrophone = isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Microphone, *document, LogFeaturePolicyFailure::No); It might be worth adding a helper function that calls both of these. > Source/WebCore/Modules/mediastream/UserMediaController.cpp:68 > + window->printErrorMessage(makeString("Not allowed to call getDisplayMedia.")); This isn't tested. > Source/WebCore/html/FeaturePolicy.cpp:65 > + document.domWindow()->printErrorMessage(makeString("Feature policy '", policyTypeName(type), "' check failed.")); Ditto. Created attachment 389511 [details]
Patch
Created attachment 389636 [details]
Rebasing for landing
Comment on attachment 389636 [details] Rebasing for landing Clearing flags on attachment: 389636 Committed r255668: <https://trac.webkit.org/changeset/255668> All reviewed patches have been landed. Closing bug. |