| Summary: | [LFC][Integration] Support intruding floats | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2020-02-02 05:14:24 PST
Created attachment 389474 [details]
wip
Created attachment 390217 [details]
patch
Comment on attachment 390217 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=390217&action=review > Source/WebCore/layout/floats/FloatingState.cpp:51 > +FloatingState::FloatItem::FloatItem(Position position, Display::Box absoluteDisplayBox) > + : m_position(position) > + , m_absoluteDisplayBox(absoluteDisplayBox) At some point this needs to be expanded to cover isDescendantOfFormattingRoot() as well (with the current integration setup/content, we don't call it). Comment on attachment 390217 [details] patch Clearing flags on attachment: 390217 Committed r256107: <https://trac.webkit.org/changeset/256107> All reviewed patches have been landed. Closing bug. |