Bug 207085

Summary:

[JSC] ShrinkToFit some vectors kept by JIT data structures

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mark.lam: review+

Description Yusuke Suzuki 2020-01-31 20:38:21 PST

[JSC] ShrinkToFit some vectors kept by JIT data structures

Comment 1 Yusuke Suzuki 2020-01-31 20:41:38 PST

Created attachment 389451 [details]
Patch

Comment 2 Yusuke Suzuki 2020-01-31 20:47:05 PST

Created attachment 389452 [details]
Patch

Comment 3 Mark Lam 2020-01-31 21:01:29 PST

Comment on attachment 389452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389452&action=review

r=me

> Source/JavaScriptCore/jit/JIT.cpp:242
> +        unsigned slowCasesBefore = m_slowCases.size();

Let’s call this previousSlowCasesSize.

Comment 4 Yusuke Suzuki 2020-01-31 21:22:04 PST

Comment on attachment 389452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389452&action=review

>> Source/JavaScriptCore/jit/JIT.cpp:242
>> +        unsigned slowCasesBefore = m_slowCases.size();
> 
> Let’s call this previousSlowCasesSize.

Sounds nice, fixed.

Comment 5 Yusuke Suzuki 2020-01-31 21:22:53 PST

Committed r255541: <https://trac.webkit.org/changeset/255541>

Comment 6 Radar WebKit Bug Importer 2020-01-31 21:23:16 PST

<rdar://problem/59084513>