Bug 207080

Summary: WebCore links to stale libANGLE.dylib instead of libANGLE.a
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, dino, ews-watchlist, graouts, justin_fan, kbr, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948, 205483, 206318    
Attachments:
Description Flags
Rename libANGLE.a to libANGLE-static.a dino: review-, dino: commit-queue-

James Darpinian
Reported 2020-01-31 16:29:09 PST
Under some circumstances that I haven't pinned down yet, WebCore will load libANGLE.dylib instead of libANGLE-shared.dylib. libANGLE.dylib is no longer produced by the build, and old stale copies are just hanging around in people's build directories, including on the bots. This is the root cause of the bot test failures that keep causing our ANGLE updates patches to be rolled back.
Attachments
Rename libANGLE.a to libANGLE-static.a (9.19 KB, patch)
2020-02-03 16:14 PST, James Darpinian 		dino: review-
dino: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-02-03 16:14:50 PST
Created attachment 389591 [details] Rename libANGLE.a to libANGLE-static.a
EWS Watchlist
Comment 2 2020-02-03 16:15:30 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2020-02-03 17:12:40 PST
Great work James diagnosing this problem from the binaries from the build bots, and coming up with a future-proof fix!
Dean Jackson
Comment 4 2020-02-04 14:15:19 PST
Comment on attachment 389591 [details] Rename libANGLE.a to libANGLE-static.a Unfortunately we can't do this, because the Apple build system will freak out that we're no longer producing a libANGLE.a, even if we update WebCore at the same time because everything is built in isolation. This is why the change to a dylib was eventually called libANGLE-shared.dylib - I learnt the hard way. The good news is that the bots with the stale file have been cleared, and if it happens again we know what to do. We'll also move to libANGLE-shared.dylib soon.
James Darpinian
Comment 5 2020-02-04 14:33:40 PST
OK, seems like the easiest thing to do is just wait for the shared library switch, and live with the possibility that some people's builds might be broken in the meantime.
Note You need to log in before you can comment on or make changes to this bug.