Bug 207017

Summary:

Can still get stuck after swipe backwards with a slow server, even after r254552

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+, cdumez: commit-queue-

Description Tim Horton 2020-01-30 14:07:21 PST

Can still get stuck after swipe backwards with a slow server, even after r254552

Comment 1 Tim Horton 2020-01-30 14:07:31 PST

Created attachment 389287 [details]
Patch

Comment 2 Tim Horton 2020-01-30 14:08:52 PST

<rdar://problem/59016256>

Comment 3 Chris Dumez 2020-01-30 14:10:08 PST

Comment on attachment 389287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389287&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:391
> +void ProvisionalPageProxy::navigationGestureDidEnd()

Can we call this something like: unfreezeLayerTreeDueToSwipeAnimation() ? Given that you're only calling this when the m_isLayerTreeFrozenDueToSwipeAnimation flag is set on the WebPageProxy.

Comment 4 Tim Horton 2020-01-30 14:28:45 PST

Heh, that was the first name I had for it. Sure!

Comment 5 Tim Horton 2020-01-30 14:31:51 PST

https://trac.webkit.org/changeset/255458/webkit