| Summary: | [CMake] Add SQLite::SQLite3 target | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ross Kirsling
2020-01-30 09:54:17 PST
Created attachment 389260 [details]
Patch
Comment on attachment 389260 [details]
Patch
r=me
Just wait for the bots.
Created attachment 389273 [details]
Patch
Comment on attachment 389273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389273&action=review > Source/cmake/OptionsAppleWin.cmake:13 > +find_package(SQLite3 3.23.1 REQUIRED) Just make it REQUIRED without the version like OptionsGTK does. The one AppleWin is using is ancient. Created attachment 389285 [details]
Patch
Comment on attachment 389285 [details] Patch Clearing flags on attachment: 389285 Committed r255475: <https://trac.webkit.org/changeset/255475> All reviewed patches have been landed. Closing bug. |