| Summary: | Don't include VM.h in CallFrame.h | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||||
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||||||
| Status: | NEW --- | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Robin Morisset
2020-01-29 14:57:01 PST
Created attachment 389192 [details]
Patch
Comment on attachment 389192 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389192&action=review > Source/JavaScriptCore/ChangeLog:9 > + This macro could as easily be declared in VM.h, and it significantly help compile times for all the files which don't use it (and so no longer have to depend on VM.h) "help" => "helps" Comment on attachment 389192 [details]
Patch
Can you add a comment next to the DECLARE_CALL_FRAME macro indicating that it was moved here from CallFrame.h so that CallFrame.h doesn’t have to include VM.h, and that this is needed to reduce build time.
Created attachment 389614 [details]
Patch
Add a comment per Mark's suggestion, and add a missing '#include "CPU.h"' which was causing failures in the 32-bit x86 EWS bot.
Created attachment 389857 [details]
Patch
rebase
Created attachment 389885 [details]
Patch
|