| Summary: | Don't include CCallHelpers.h in B3Procedure.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Robin Morisset
2020-01-29 14:17:30 PST
Created attachment 389185 [details]
Patch
Created attachment 389186 [details]
fix style nit
Comment on attachment 389186 [details] fix style nit View in context: https://bugs.webkit.org/attachment.cgi?id=389186&action=review > Source/JavaScriptCore/b3/testb3_6.cpp:2176 > + CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0)); should we also make AirCode not use Label directly? (In reply to Saam Barati from comment #3) > Comment on attachment 389186 [details] > fix style nit > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389186&action=review > > > Source/JavaScriptCore/b3/testb3_6.cpp:2176 > > + CodeLocationLabel<B3CompilationPtrTag> labelOne = linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0)); > > should we also make AirCode not use Label directly? We could also make Label not depend on AssemblerLabel/Masm since we only have one type per compilation target Comment on attachment 389186 [details] fix style nit Clearing flags on attachment: 389186 Committed r255394: <https://trac.webkit.org/changeset/255394> All reviewed patches have been landed. Closing bug. |