Bug 206923
| Summary: | Content blocker: ignore and report problematic rules instead of refusing to load the whole content blocker | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrey Meshkov <am> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | achristensen, krzysztof.modras, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Andrey Meshkov
The problem with the current approach is that any invalid rule breaks the content blocker completely. Also, there's no way to learn what exact rule is invalid, we even had to come up with a script that uses some kind of a "binary search" algorithm to find problematic rules. Overall, this experience is really painful for people who are trying to create content blockers.
Here's what I suggest:
1. Ignore problematic rules instead of throwing out the whole content blocker.
2. Extend the setContentBlocker callback parameter and put a list with the problematic rules there.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/59005370>