| Summary: | [iOS][WK2] Drop process assertion logic for holding locked files | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, beidson, ggaren, sihui_liu, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 213194 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2020-01-28 14:45:43 PST
Created attachment 389068 [details]
Patch
Created attachment 389071 [details]
Patch
Created attachment 389074 [details]
Patch
Comment on attachment 389074 [details]
Patch
Will investigate iOS api test failures.
Comment on attachment 389074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389074&action=review > Source/WebKit/ChangeLog:22 > + those processes will make sure to suspend their database threads to prevent any I remember further database work would be stopped only when the suspension is imminent or there is no ongoing transaction. If the concept of imminent suspension is still there, we need to also set IsSuspensionImminent::Yes, or set ShouldForceStop::No in WebIDBServer::suspend. A nice thing about having the logic is we don't force aborting ongoing transaction if we know a message of holding file lock has been sent. Created attachment 397845 [details]
Patch
Created attachment 397846 [details]
Patch
Committed r260856: <https://trac.webkit.org/changeset/260856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397846 [details]. Looks like this got reverted, but the bug is still RESOLVED/FIXED. |