| Summary: | TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aestes, ap, commit-queue, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-01-28 14:33:50 PST
Created attachment 389065 [details]
Patch
Comment on attachment 389065 [details]
Patch
rs=me, please double-check that this macro actually leaves the code enabled for iOS.
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. For reference sake, USE(QUICK_LOOK) is currently defined like so: #if PLATFORM(IOS) #define USE_QUICK_LOOK 1 #endif Created attachment 389076 [details]
Patch for landing
> For reference sake, USE(QUICK_LOOK) is currently defined like so:
What I asked to verify was whether the definition was included in this file.
Comment on attachment 389076 [details] Patch for landing Clearing flags on attachment: 389076 Committed r255320: <https://trac.webkit.org/changeset/255320> All reviewed patches have been landed. Closing bug. (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 389065 [details] > Patch > > rs=me, please double-check that this macro actually leaves the code enabled > for iOS. That would also be yes. config.h -> wtf/Platform.h -> wtf/PlatformUse.h |