| Summary: | [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, aperez, commit-queue, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Don Olmstead
2020-01-28 11:08:29 PST
Created attachment 391797 [details]
WIP Patch
Created attachment 391801 [details]
WIP Patch
Created attachment 391809 [details]
Patch
Created attachment 391823 [details]
Patch
Comment on attachment 391823 [details]
Patch
The WPE/GTK parts of the patch look good. The Windows bits also look
fine to me but I can't be 100% sure so you might want to have some
other pair of eyes glance at it before landing.
The commit-queue encountered the following flaky tests while processing attachment 391823 [details]: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) The commit-queue is continuing to process your patch. Comment on attachment 391823 [details] Patch Clearing flags on attachment: 391823 Committed r257565: <https://trac.webkit.org/changeset/257565> All reviewed patches have been landed. Closing bug. This was rolled out Created attachment 395541 [details]
Patch reland
Comment on attachment 395541 [details]
Patch reland
This fixes the issue with WinCairo that caused the roll out.
Committed r259563: <https://trac.webkit.org/changeset/259563> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395541 [details]. |