Bug 206868

Summary:

Regression: 30+ layout-test crash on Windows

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, ap, cfleizach, commit-queue, dmazzoni, ews-watchlist, hi, jcraig, jdiggs, samuel_white, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=206828

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2020-01-28 05:27:00 PST

30+ layout-test are crashing on Windows. This is a recent regression.

e.g.:
Build: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4754
Results: https://build.webkit.org/results/Apple%20Win%2010%20Release%20(Tests)/r255170%20(4754)/results.html


Dashboard: https://results.webkit.org/?suite=layout-tests&test=accessibility%2Fnon-data-table-cell-title-ui-element.html

It indicates regression range between r255161-r255170.

Comment 1 Aakash Jain 2020-01-28 05:27:33 PST

Another example:
Build: https://ews-build.webkit.org/#/builders/10/builds/4991
Result: https://ews-build.webkit.org/results/Windows-EWS/r388929-4991-clean-tree/results.html

Crash log: https://ews-build.webkit.org/results/Windows-EWS/r388929-4991-clean-tree/accessibility/anonymous-render-block-in-continuation-causes-crash-crash-log.txt

Comment 2 Alexey Proskuryakov 2020-01-28 11:04:12 PST

    Frame[00]  Triage Symbol: [WebKit!AccessibleDocument::document+0xf]
    Frame[01]  Triage Symbol: [WebKit!WebFrame::accessible+0x46]
    Frame[02]  Ignore Symbol: [WebKit!WebView::WebViewWndProc+0x5a8]

There was only one accessibility change in that range, https://trac.webkit.org/r255167

Comment 3 Radar WebKit Bug Importer 2020-01-28 11:04:20 PST

<rdar://problem/58961838>

Comment 4 Andres Gonzalez 2020-01-28 11:52:12 PST

Created attachment 389044 [details]
Patch

Comment 5 WebKit Commit Bot 2020-01-28 12:51:33 PST

Comment on attachment 389044 [details]
Patch

Clearing flags on attachment: 389044

Committed r255270: <https://trac.webkit.org/changeset/255270>

Comment 6 WebKit Commit Bot 2020-01-28 12:51:35 PST

All reviewed patches have been landed.  Closing bug.