Bug 206851

Summary: Remove the include of BytecodeGenerator.h in CodeCache.h
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206720    
Attachments:
Description Flags
Patch none

Description Robin Morisset 2020-01-27 16:30:52 PST 
This is a blocker for https://bugs.webkit.org/show_bug.cgi?id=206720.
Even by itself, it should help for compile times, since BytecodeGenerator.h includes the huge BytecodeStructs.h and CodeCache.h is included in quite a few places.
Comment 1 Robin Morisset 2020-01-27 16:39:13 PST 
Created attachment 388936 [details]
Patch
Comment 2 Tadeu Zagallo 2020-01-27 16:53:16 PST 
Comment on attachment 388936 [details]
Patch

r=me
Comment 3 Mark Lam 2020-01-27 16:59:07 PST 
r=me too.
Comment 4 WebKit Commit Bot 2020-01-28 16:22:22 PST 
Comment on attachment 388936 [details]
Patch

Clearing flags on attachment: 388936

Committed r255321: <https://trac.webkit.org/changeset/255321>
Comment 5 WebKit Commit Bot 2020-01-28 16:22:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-28 16:23:13 PST 
<rdar://problem/58974442>