| Summary: | WebCore: Guard uneven corners in rounded rectangles | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206096 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-01-27 13:03:05 PST
Not 100% certain this should be a USE macro, but it seems more fitting then a HAVE macro. Created attachment 388889 [details]
Patch
Comment on attachment 388889 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388889&action=review > Source/WTF/wtf/PlatformUse.h:312 > +#define USE_CG_PATH_ADD_UNEVEN_CORNERS_ROUNDEDRECT 1 I think this should be a HAVE_ in PlatformHave.h Created attachment 388928 [details]
Patch
Comment on attachment 388928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388928&action=review > Source/WTF/wtf/PlatformHave.h:569 > +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(MACCATALYST) I think we might want to consider a slightly more forward-looking version of the check: #if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101400) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) Created attachment 389002 [details]
Patch
Comment on attachment 389002 [details] Patch Clearing flags on attachment: 389002 Committed r255255: <https://trac.webkit.org/changeset/255255> All reviewed patches have been landed. Closing bug. |