Bug 206833

Summary: Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, jbedard, tuomas.webkit, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206389    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Robin Morisset 2020-01-27 10:14:08 PST 
https://bugs.webkit.org/show_bug.cgi?id=206389 introduced two options in Tools/Scripts/set-webkit-configuration, but did not adapt the check that at least one valid option is passed.
So the following works: set-webkit-configuration --no-asan --no-coverage
But the following is rejected: set-webkit-configuration --no-asan.

The fix should be trivial.
Comment 1 Robin Morisset 2020-01-27 10:24:15 PST 
Created attachment 388872 [details]
Patch
Comment 2 Tuomas Karkkainen 2020-01-27 10:25:40 PST 
looks good. thank you!
Comment 3 WebKit Commit Bot 2020-01-27 12:18:49 PST 
Comment on attachment 388872 [details]
Patch

Clearing flags on attachment: 388872

Committed r255160: <https://trac.webkit.org/changeset/255160>
Comment 4 WebKit Commit Bot 2020-01-27 12:18:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-27 12:19:16 PST 
<rdar://problem/58929211>