Bug 206825

Summary: webkitpy: Replace StringIO.StringIO in statusserver.py
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2020-01-27 07:50:19 PST
This bug was brought to my attention in https://bugs.webkit.org/show_bug.cgi?id=206801, and is apparently not covered in our unit testing.
Comment 1 Jonathan Bedard 2020-01-27 07:51:50 PST
Created attachment 388858 [details]
Patch
Comment 2 Aakash Jain 2020-01-27 07:56:54 PST
Comment on attachment 388858 [details]
Patch

This is actually dead code after https://trac.webkit.org/changeset/255123/webkit
I plan to delete a lot of code of old EWS after moving commit-queue.

But I am fine with fixing this issue meanwhile.
Comment 3 Jonathan Bedard 2020-01-27 08:00:44 PST
(In reply to Aakash Jain from comment #2)
> Comment on attachment 388858 [details]
> Patch
> 
> This is actually dead code after
> https://trac.webkit.org/changeset/255123/webkit
> I plan to delete a lot of code of old EWS after moving commit-queue.
> 
> But I am fine with fixing this issue meanwhile.

Good to know.

I'll land this now, but I look forward to the incoming deletion patches!
Comment 4 WebKit Commit Bot 2020-01-27 08:32:00 PST
Comment on attachment 388858 [details]
Patch

Clearing flags on attachment: 388858

Committed r255148: <https://trac.webkit.org/changeset/255148>
Comment 5 WebKit Commit Bot 2020-01-27 08:32:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-27 08:32:13 PST
<rdar://problem/58919230>
Comment 7 Aakash Jain 2020-03-27 15:21:06 PDT
(In reply to Jonathan Bedard from comment #3)
> I look forward to the incoming deletion patches!
Bug 209683 deletes a lot of code.