Bug 206819

Summary:

[Web Animations] Update all DocumentTimeline objects when updating animations

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dbates, dino, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Antoine Quint 2020-01-26 23:49:09 PST

[Web Animations] Update all DocumentTimeline objects when updating animations

Comment 1 Antoine Quint 2020-01-26 23:52:02 PST

Created attachment 388835 [details]
Patch

Comment 2 Antti Koivisto 2020-01-27 02:41:32 PST

Comment on attachment 388835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388835&action=review

> Source/WebCore/dom/Document.h:2042
> +    Vector<WeakPtr<DocumentTimeline>> m_timelines;

You might want to use WeakHashSet instead if ordering doesn't matter.

Comment 3 Antoine Quint 2020-01-27 04:01:31 PST

Committed r255141: <https://trac.webkit.org/changeset/255141>

Comment 4 Radar WebKit Bug Importer 2020-01-27 04:02:18 PST

<rdar://problem/58914325>